Update simulation test #2984
Update simulation test #2984
Conversation
WalkthroughThe pull request introduces modifications to the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🔇 Additional comments (5)go.mod (1)
All irisnet modules have been updated to version ✅ Verification successfulLet me try another approach to verify the module changes by checking the go.mod file directly. Let me check the actual usage of these modules in the codebase to verify if there are any potential compatibility issues. Based on the analysis of the codebase, I can now provide a final response: Module updates appear safe and coordinated The version updates for all irisnet modules are part of a coordinated release. The code inspection shows:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for any breaking changes or compatibility issues in the updated modules
# Get the commit messages between the old and new versions for all modules
for module in coinswap farm htlc mt nft oracle random record service token; do
echo "Checking $module changes..."
gh api graphql -f query='
{
repository(owner: "irisnet", name: "modules") {
object(expression: "main") {
... on Commit {
history(first: 10, since: "2024-12-17T08:01:51Z", until: "2024-12-19T09:14:34Z", path: "'$module'") {
nodes {
messageHeadline
committedDate
}
}
}
}
}
}'
done
Length of output: 5813 Script: #!/bin/bash
# Check the go.mod file for any replace directives and version information
cat go.mod
# Also check if there are any breaking changes in imports or API usage
rg -l "mods\.irisnet\.org/modules/(coinswap|farm|htlc|mt|nft|oracle|random|record|service|token)" --type go
Length of output: 14060 Script: #!/bin/bash
# Check how these modules are used in the codebase
for file in app/modules.go app/keepers/keepers.go app/ante/decorators.go; do
echo "=== Checking $file ==="
cat "$file"
done
# Also check if there are any breaking changes in the imports
rg -A 3 "mods\.irisnet\.org/modules/(coinswap|farm|htlc|mt|nft|oracle|random|record|service|token)" --type go
Length of output: 57012 app/sim_test.go (4)
Adding the assert package from testify is a good practice as it provides better testing utilities and more readable assertions.
The enhanced error handling for InitGenesis is more robust:
The store comparison has been improved:
Added additional staking store keys for comparison:
This ensures more thorough validation of staking-related state during import/export tests. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Closed: #2977 #2976
Summary by CodeRabbit
Bug Fixes
Chores